Skip to content

Conversation

@ItoroD
Copy link
Collaborator

@ItoroD ItoroD commented Oct 28, 2025

Description

Notes to the reviewers

Added more useful methods for DerivationPath for now I added the simplest ones. More should be added later; like child, into_child.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@ItoroD ItoroD force-pushed the derivationpath-method branch 2 times, most recently from 37561a5 to 68670ac Compare October 28, 2025 18:01
@ItoroD ItoroD requested a review from thunderbiscuit October 28, 2025 18:18
@reez
Copy link
Collaborator

reez commented Oct 29, 2025

I dig this addition. Are you going to add #[uniffi::export(Display)] to DerivationPath?

@ItoroD ItoroD force-pushed the derivationpath-method branch from 68670ac to a9875c2 Compare October 29, 2025 23:44
@ItoroD ItoroD force-pushed the derivationpath-method branch from a9875c2 to 6544423 Compare October 29, 2025 23:46
@ItoroD
Copy link
Collaborator Author

ItoroD commented Oct 29, 2025

I dig this addition. Are you going to add #[uniffi::export(Display)] to DerivationPath?

Good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants