Skip to content

Conversation

@evanlinjin
Copy link
Member

No description provided.

@evanlinjin evanlinjin requested a review from ValuedMammal May 14, 2025 05:31
@ValuedMammal
Copy link
Collaborator

I noticed a few compile errors in examples/common.rs as a result of updating the dev-dependencies that I think can be easily addressed, other than that the changes to Cargo.toml look ok to me.

- `large_enum_variant`
- `result_large_error`

These are planned to be addressed in a future PR.
Add missing type alias for `HashSet`, and better
separation of cfg feature attributes.
@ValuedMammal
Copy link
Collaborator

I added ea61aff in order to appease CI, assuming it can be fixed in #5.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-ACK d7eae73

@ValuedMammal ValuedMammal merged commit 19d9578 into bitcoindevkit:master May 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants