-
Notifications
You must be signed in to change notification settings - Fork 419
feat(rpc): introduce FilterIter #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): introduce FilterIter #1614
Conversation
|
This is what we've all been waiting for. |
f001fd4 to
aa8c49e
Compare
|
ConceptACK. Don't have time for a full review now. @evanlinjin? |
|
Thanks for the review @oleonardolima |
7d34480 to
f74580c
Compare
|
Rebased and addressed comments from @oleonardolima |
455c16c to
1074412
Compare
1074412 to
c0f16e0
Compare
c0f16e0 to
db65d96
Compare
|
In the last push
CI failure seems unrelated |
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK db65d96
19a5926 to
7ad95d3
Compare
|
Rebased |
nymius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 7ad95d3
7ad95d3 to
8fc03ee
Compare
|
Rebased |
a36a5a8 to
f34cc9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK a6364e2
This is cool stuff, I added some docs to make it easier for others to run.
f34cc9b to
a6364e2
Compare
|
Thanks @notmandatory |
|
We need to test this against reorgs. It seems like the architecture of this may result in inconsistent state of checkpoints during reorgs.
|
The PR adds a
bip158module to thebdk_bitcoind_rpccrate along with a new typeFilterIterthat can be used for retrieving blocks from a full node which contain transactions relevant to a list of script pubkeys.Notes to the reviewers
Changelog notice
bdk_bitcoind_rpc: Addedbip158module as a means of updatingbdk_chainstructuresChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: