example_cli: use bdk_tx to create PSBTs
#1894
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aagbotemi
reviewed
Mar 20, 2025
| @@ -87,7 +87,7 @@ impl EsploraArgs { | |||
| #[derive(Parser, Debug, Clone, PartialEq)] | |||
| pub struct ScanOptions { | |||
| /// Max number of concurrent esplora server requests. | |||
| #[clap(long, default_value = "5")] | |||
| #[clap(long, default_value = "2")] | |||
There was a problem hiding this comment.
I think the default value of concurrent request is good at 5. While lower value might reduce the risk of overloading the system, using 5 allows more operation to run in parallel, and make a process to complete faster, which will help to improve overall performace.
There was a problem hiding this comment.
Thanks @aagbotemi Since this was part of #1840 I left it as is. The option is configurable from the command line and if the default turns out to be too slow, we can change it back.
ValuedMammal
force-pushed
the
example/cli-build-psbt
branch
from
ddc0225 to
0c55a8d
Compare
ValuedMammal
changed the title
bdk_tx to create PSBTs
ValuedMammal
force-pushed
the
example/cli-build-psbt
branch
from
0c55a8d to
c397fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be used for testing transaction creation using "bdk-tx" which is still a new and mostly untested project. I may also use this as a place to collect any issues or findings that come up during testing.
builds on #1840
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing