Skip to content

Conversation

@Musab1258
Copy link
Contributor

Description

The publish_docs workflow pushes changes to this repository: "bitcoindevkit/bitcoindevkit.org" which requires valid credentials. By setting the persist-credentials to false in #1778, the credentials required are not made available.

Notes to the reviewers

To fix the issue I added a write permission to the publish_jobs, which will allow it to push changes without the credentials.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@Musab1258 Musab1258 marked this pull request as draft March 17, 2025 14:10
@Musab1258 Musab1258 marked this pull request as ready for review March 17, 2025 16:10
@Musab1258 Musab1258 marked this pull request as draft March 17, 2025 16:13
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Chain Mar 17, 2025
@ValuedMammal ValuedMammal moved this from Needs Review to In Progress in BDK Chain Mar 17, 2025
@ValuedMammal ValuedMammal linked an issue Mar 17, 2025 that may be closed by this pull request
@Musab1258 Musab1258 marked this pull request as ready for review March 17, 2025 17:18
@notmandatory notmandatory added this to the 1.2.0 milestone Mar 17, 2025
@notmandatory notmandatory moved this to In Progress in BDK Wallet Mar 17, 2025
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Chain Mar 17, 2025
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Wallet Mar 17, 2025
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8b0b3a4

I agree with @ValuedMammal this is worth a try.

@Musab1258 If this doesn't fix the issue please create a new PR to roll it back. Thanks!

@notmandatory notmandatory merged commit 2f333c8 into bitcoindevkit:master Mar 17, 2025
39 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Mar 17, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Mar 17, 2025
@notmandatory
Copy link
Member

I think I have a working fix in #1896 which also reverts this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

CI: Publish docs job fails with "Permission denied"

3 participants