Skip to content

test for excluded bounds in outputs_in_range #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test for excluded bounds in outputs_in_range #1897

wants to merge 1 commit into from

Conversation

aagbotemi
Copy link

Description

This PR covers a wide range on tests for excluded bounds and the SpkTxOutIndex::outputs_in_range. This PR fixes bitcoindevkit/bdk_wallet#58

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@aagbotemi aagbotemi mentioned this pull request Mar 18, 2025
Open
@ValuedMammal ValuedMammal added the audit Suggested as result of external code audit label Mar 18, 2025
@notmandatory notmandatory moved this to In Progress in BDK Chain Apr 23, 2025
@GideonBature
Copy link

tACK #1897

Tested and working as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aagbotemi aagbotemi

Labels
audit Suggested as result of external code audit tests
Projects
BDK Chain
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test excluded bounds in SpkTxOutIndex::outputs_in_range
3 participants
@aagbotemi @GideonBature @ValuedMammal