-
Notifications
You must be signed in to change notification settings - Fork 389
feat!(chain): implement first_seen
tracking
#1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Some quirks that requires changing in the tests. Also, ChainPosition
field order should be changed to make proper use of derive(Ord)
.
Other things to take note of:
- Documentation comments need full stops!
- Will be nice to include the module changed in commit messages. I.e.
feat(chain):
signals that we are changing thebdk_chain
crate.
b38d154
to
1d6fb3c
Compare
first_seen
trackingfirst_seen
tracking
180e4ee
to
352ccbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just documentation suggestions.
first_seen
trackingfirst_seen
tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8b17bcf
Description
This PR solves issue #1947 by implementing
first_seen
tracking.Added
first_seen
field toTxGraph
andChangeSet
so thatfirst_seen
timestamp can be added when inserting a new seen-at usinginsert_seen_at
.first_seen
added toTxNode
as a way to retrieve the first-seen timestamp for a transaction.first_seen
added toChainPosition::Unconfirmed
to order unconfirmed transactions byfirst_seen
.New tests have been added for the above described functionalities.
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: