Skip to content

Conversation

@evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Sep 11, 2025

Description

All last_evicted field to TxNode and remove TxGraph::get_last_evicted method.

Notes to the reviewers

get_last_evicted was added as adding fields to TxNode is a breaking change. However, we are going to break bdk_chain in the next release so a breaking change now is okay.

Changelog notice

Added:
- `last_evicted` field is added to `TxNode`.

Removed:
- `TxGraph::get_last_evicted` method is removed.

Checklists

All Submissions:

New Features:

* [ ] I've added tests for the new feature

  • I've added docs for the new feature

Also remove `TxGraph::get_last_evicted` method.
@evanlinjin evanlinjin added this to the Wallet 3.0.0 milestone Sep 11, 2025
@evanlinjin evanlinjin self-assigned this Sep 11, 2025
@evanlinjin evanlinjin added the api A breaking API change label Sep 11, 2025
@evanlinjin evanlinjin force-pushed the feature/add-last-evicted-to-txnode branch from 4a68c94 to 3fb768b Compare September 11, 2025 06:56
@evanlinjin evanlinjin moved this to Needs Review in BDK Chain Sep 11, 2025
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3fb768b

Copy link
Contributor

@LagginTimes LagginTimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3fb768b

@evanlinjin evanlinjin merged commit faf520d into bitcoindevkit:master Sep 15, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants