Skip to content

fix: Validate prevouts in get_psbt_input #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented May 16, 2025

Fixes #50
Fixes #51
Replaces bitcoindevkit/bdk#1911
Replaces bitcoindevkit/bdk#1913

Description

We should check the bounds of the prev txs.

Changelog notice

Fixed:
    - Wallet::get_psbt_input method now checks bounds when fetching prevout
    - Wallet::build_fee_bump method now checks bounds when fetching prevout

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

* [ ] I've added tests to reproduce the issue which are now passing

  • I'm linking the issue being fixed by this PR

@coveralls
Copy link

coveralls commented May 16, 2025

Pull Request Test Coverage Report for Build 15063236968

Details

  • 15 of 19 (78.95%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 86.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wallet/src/wallet/error.rs 0 2 0.0%
wallet/src/wallet/mod.rs 15 17 88.24%
Totals Coverage Status
Change from base Build 14921254296: -0.009%
Covered Lines: 7273
Relevant Lines: 8451

💛 - Coveralls

Added `InvalidOutputIndex` variant to `BuildFeeBumpError`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Validate UTXO data for build_fee_bump Validate previous tx outputs for get_psbt_input
3 participants