Skip to content

Conversation

@ValuedMammal
Copy link
Collaborator

Description

This is a draft PR refactoring build_fee_bump in attempt to resolve #325.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@ValuedMammal ValuedMammal requested a review from nymius October 29, 2025 17:39
@ValuedMammal ValuedMammal marked this pull request as draft October 29, 2025 17:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18917041894

Details

  • 43 of 43 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.136%

Totals Coverage Status
Change from base Build 18891447990: 0.1%
Covered Lines: 7005
Relevant Lines: 8228

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Can't build a fee bump transaction if spending a P2A output

2 participants