Skip to content

Conversation

@ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Sep 25, 2024

Clean up after #98 which accidentally exposed get_with_retry publicly for the blocking client.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11034104409

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.071%

Totals Coverage Status
Change from base Build 11025318001: 0.0%
Covered Lines: 1041
Relevant Lines: 1182

💛 - Coveralls

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bfaa9ae

@oleonardolima oleonardolima added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 25, 2024
@ValuedMammal ValuedMammal merged commit ae9edf9 into bitcoindevkit:master Sep 26, 2024
25 checks passed
@ValuedMammal ValuedMammal deleted the fix/blocking-retry branch October 3, 2024 22:25
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
…_retry` is private method

bfaa9ae546e4087c1a81c653333ee9b1c949e0ce fix(blocking): `get_with_retry` is private method (valued mammal)

Pull request description:

  Clean up after #98 which accidentally exposed `get_with_retry` publicly for the blocking client.

ACKs for top commit:
  oleonardolima:
    ACK bfaa9ae546e4087c1a81c653333ee9b1c949e0ce

Tree-SHA512: 33abd34e919e27069107947c34915b9de3547ab1d78291841f2052552abd23fd59621ee6ae3ed9bd8e3eda608c2e5b9285529df1dcba8a4a1705ca1f1491c136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants