Skip to content

Conversation

@oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Oct 27, 2025

To fix the MSRV CI steps, the following dependencies
needed to be pinned to a previous version:

I want to fix the CI so we can move forward with #114. After we cut a release with that one, we can move on to bumping the MSRV.

@coveralls
Copy link

coveralls commented Oct 27, 2025

Pull Request Test Coverage Report for Build 18850046660

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.216%

Totals Coverage Status
Change from base Build 17164013618: 0.0%
Covered Lines: 1037
Relevant Lines: 1189

💛 - Coveralls

@oleonardolima oleonardolima self-assigned this Oct 27, 2025
@oleonardolima oleonardolima added the ci Continuous Integration issues label Oct 27, 2025
@oleonardolima oleonardolima moved this to In Progress in BDK Chain Oct 27, 2025
@oleonardolima oleonardolima force-pushed the ci/pin-socket2-dep branch 3 times, most recently from 354c061 to be3111a Compare October 27, 2025 17:21
In order to fix the MSRV CI steps the following dependencies
needed to be pinned to a previous version:

- `[email protected]`
- `[email protected]`
- `openssl`
- `openssl-sys`
- `syn`
@oleonardolima oleonardolima marked this pull request as ready for review October 27, 2025 17:31
@oleonardolima oleonardolima changed the title fix(ci): pin [email protected] and [email protected] fix(ci): pin dependencies to MSRV supported versions Oct 27, 2025
@oleonardolima oleonardolima moved this from In Progress to Needs Review in BDK Chain Oct 27, 2025
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a7e826

@ValuedMammal ValuedMammal merged commit 8f3a67e into bitcoindevkit:master Oct 27, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Oct 27, 2025
@oleonardolima oleonardolima deleted the ci/pin-socket2-dep branch October 27, 2025 19:10
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
…s to MSRV supported versions

9a7e826f0a3ddf145bf15080274b6bc231dc5228 fix(ci): pin dependencies to MSRV supported version (Leonardo Lima)

Pull request description:

  To fix the MSRV CI steps, the following dependencies
  needed to be pinned to a previous version:

  - `[email protected]` to 0.5.10
  - `[email protected]` to 1.0.1
  - `openssl` to 0.10.73
  - `openssl-sys` to 0.9.109
  - `syn` to 2.0.106

  I want to fix the CI so we can move forward with #114. After we cut a release with that one, we can move on to bumping the MSRV.

ACKs for top commit:
  ValuedMammal:
    ACK 9a7e826f0a3ddf145bf15080274b6bc231dc5228

Tree-SHA512: 4a13e03a1c66ba554926686149f5fc33ec926a11c94228a3402b87317c6e8958034483a04de84c072092c785de6229ff484da6ee8a3de33781788b5780139cb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants