Setting persistent parameters through app api

[thewired-nl]

param_logic.h has functions for getting/setting parameters from within the code (like apps). However, this does not update persistent parameters in EEPROM. The paramPersistentStore function that handles this when done through CRTP is explicitly marked for internal use only (in the paramTask).

For now I've hacked around this limitation by replacing the CRTP link so I can inject packets, but that's obviously not ideal

[ArisMorgens]

Hello @thewired-nl!

Thanks for pointing this out. I pushed a branch in crazyflie-firmware that should allow this functionality:
https://github.com/bitcraze/crazyflie-firmware/tree/Aris/persistent_param

It basically adds paramPersistentStoreByVarId(paramVarId_t varid) to the public API in param_logic.h, following the same pattern as paramSetInt/Float. Check it out and let me know what you think!

[thewired-nl]

This looks great! Unfortunately I forgot about another limiting factor in my usecase, where this is running in an ISR, so the normal semaphore functions don't work. I will move the handling code out of the interrupt and test again, thanks!

[thewired-nl]

Outside the ISR this patch works as expected

[ArisMorgens]

Thank you for testing! I will create a PR with these changes.
Do you think that this issue is then resolved, or do we need to further investigate it?

[thewired-nl]

Yeah the PR resolves this issue, commented there as well wrt example code