Skip to content

EPROD-1156-live mode on pocket ic client #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veeso merged 4 commits into from
Mar 21, 2025
Merged

EPROD-1156-live mode on pocket ic client #245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f78ad1
EPROD-1156-live mode on pocket ic client
veeso Mar 11, 2025
25fba0d
fix: docs
veeso Mar 11, 2025
827e7fe
fix: docs
veeso Mar 11, 2025
99ec2f7
fix: no live methods, just use getters
veeso Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ic-canister-client/src/pocket_ic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,17 @@ impl PocketIcClient {
{
let args = candid::encode_args(args)?;

let reply = self
.client()
.update_call(self.canister, self.caller, method, args)
.await?;
let reply = if self.is_live() {
let id = self
.client()
.submit_call(self.canister, self.caller, method, args)
.await?;
self.client().await_call_no_ticks(id).await
} else {
self.client()
.update_call(self.canister, self.caller, method, args)
.await
}?;

let decoded = Decode!(&reply, R)?;
Ok(decoded)
Expand All @@ -75,6 +82,14 @@ impl PocketIcClient {
let decoded = Decode!(&reply, R)?;
Ok(decoded)
}

/// Returns true if the client is live.
fn is_live(&self) -> bool {
self.client
.as_ref()
.map(|client| client.url().is_some())
.unwrap_or_default()
}
}

#[async_trait::async_trait]
Expand Down