-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UnifiedPush Connector 3.x #1325
base: main-ose
Are you sure you want to change the base?
Conversation
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
This PR/issue depends on: |
Even when using the upstream version you'd have the same issue. It means you have another dependency using tink (or another dependency). You'll probably want to see what other dependency depends on it to check it uses an updated version of tink. You may want to explicitly depend on tink to control the version. By the way, the upstream tink:webpush-app uses an outdated tink, see: https://codeberg.org/UnifiedPush/android-connector/issues/5#issue-1037639 |
Tip
Cannot properly test because we still do not support encryption with our current implementation of DAVPush.
Depends on bitfireAT/dav4jvm#64
Purpose
Upgrade the UnifiedPush connector version to the latest one (3.0.4). This one includes built-in support for message encryption.
Also gives support to DAVPush encryption with VAPID and message encryption.
Right now we do not have any working server and/or implemented with support for push with encryption, so I'm not sure how to test it.
Short description
Upgrade UnifiedPush Connector.
Note that there seems to be a bug in a dependency they use, so they import it locally:
https://github.com/UnifiedPush/android-connector/blob/28cb0d622ed0a972996041ab9cc85b701abc48c6/connector/build.gradle#L56-L59
It breaks the build because of duplicated libraries, so I've had to exclude it from UnifiedPush. I guess that when Fix spec compliant record size verification tink-crypto/tink-java-apps#5 is merged they will release a new version.
For some reason push is broken right now, I don't know if it's our fault, UnifiedPush's fault, or the Nextcloud server's fault.
Checklist