-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added widget with just a sync icon #1340
base: main-ose
Are you sure you want to change the base?
Conversation
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Not really a thing that needs to be done quickly, but at least it's something, and since those files are pretty much never modified, we can just leave this ready until we want to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, but wow that is a lot of new code. I can't help but think it would be less if we had only one widget.
Is it hard to make it one widget only, which resizes and then simply hides and shows the text depending on the widget size? Without the text they are exactly the same, no?
Also, does it need to be a circle? When adding the widget I can see the widget as a square, with/without rounded borders (depending on the widget settings) for a very short time before it goes back to circle again. I could think of users who want it to behave like the other widgets do. That is to have a full background color for the widget which is cropped by the widget setting and not enforce the rounded corners (circle shape) ourselves.
I took the screenshot at the right moment, but it turns back into a circle right after:
No, it should be easy, but I think @devvv4ever told me to have two different widgets, in case anyone wants a small widget with text |
Not technically, but I guess we can choose |
Purpose
Some people is requesting a simple square widget to run synchronization for DAVx⁵ manually, this adds a new widget to extend the existing one.
Short description
Added a new widget with just an icon, that runs synchronization when clicked:
Screenshot
This doesn't exclude the already existing one with a label, but gives a new simpler option to the users.
TODO:
For some reason both widgets have the same label, it would be cool to be able to differentiate them.
Fixed
It would be cool to show a proper preview to know how the widget will look like.
Fixed
Checklist