Fixed paddings on horizontal mode

[ArnyminerZ]

Purpose

Horizontal mode's paddings are not correct, causing some parts of the UI to be overlaid by the system UI. See #1346 for examples.

Short description

• Fixed padding for the side menu on landscape mode.
• Fixed padding for FAB on landscape mode and 3-button navigation enabled.
• Fixed text overlap with display cutout in horizontal mode.

Landscape mode accounts screen

Sidebar fix

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[ArnyminerZ]

I really think that those are simply Android bugs, but we should fix them, at least until Google does something.

Edge-to-edge is really buggy and strange, and for some reason they are enforcing it

[sunkup]

I really think that those are simply Android bugs, but we should fix them, at least until Google does something.

What makes you think that? In the docs they say we got to handle it manually ourselves. https://developer.android.com/develop/ui/compose/system/cutouts#handle-cutout

So I don't think google considers it an android bug ...

[sunkup]

Works fine for accounts screen. But there are still some views that are missing, like the Webdav mounts (FAB). There may be more. Probably also a good idea to check the buy badges view in the gplay variant.

[sunkup]

Actually I think that, when in landscape mode, we should not let the content area extend into the cutout areas at all.

[mbiebl]

Actually I think that, when in landscape mode, we should not let the content area extend into the cutout areas at all.

I guess it get's even more complicated on Tablets and split-window mode.
Is there maybe a better way to handle this than simply basing this on whether we are in landscape mode or not?

[ArnyminerZ]

I've simply added a bounding box to all views that makes sure nothing overlays anything:

Accounts screen

Side panel

Webdav mounts

Vertical works correctly as well. Only downside is that content cannot be under the navigation bar, but I guess it's just better to keep it this way.

[sunkup]

When in portrait orientation in the accounts view:

1. turn the device to landscape orientation
2. open the account

Now the space left and right is missing. FABs are under the navigation again. This is probably true for other views as well.

[ArnyminerZ]

Now the space left and right is missing. FABs are under the navigation again. This is probably true for other views as well.

Did you re-build it? I'm not having that issue 🤔

Edit: okay, I guess you used API 34, it's as you've said there.

Intro

Accounts