Fixed paddings on horizontal mode

[ArnyminerZ]

Purpose

Horizontal mode's paddings are not correct, causing some parts of the UI to be overlaid by the system UI. See #1346 for examples.

Short description

• Fixed padding for the side menu on landscape mode.
• Fixed padding for FAB on landscape mode and 3-button navigation enabled.
• Fixed text overlap with display cutout in horizontal mode.

Landscape mode accounts screen

Sidebar fix

Further information

https://developer.android.com/codelabs/edge-to-edge#4

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[ArnyminerZ]

I really think that those are simply Android bugs, but we should fix them, at least until Google does something.

Edge-to-edge is really buggy and strange, and for some reason they are enforcing it

[sunkup]

I really think that those are simply Android bugs, but we should fix them, at least until Google does something.

What makes you think that? In the docs they say we got to handle it manually ourselves. https://developer.android.com/develop/ui/compose/system/cutouts#handle-cutout

So I don't think google considers it an android bug ...

[sunkup]

Works fine for accounts screen. But there are still some views that are missing, like the Webdav mounts (FAB). There may be more. Probably also a good idea to check the buy badges view in the gplay variant.

[sunkup]

Actually I think that, when in landscape mode, we should not let the content area extend into the cutout areas at all.

[mbiebl]

Actually I think that, when in landscape mode, we should not let the content area extend into the cutout areas at all.

I guess it get's even more complicated on Tablets and split-window mode.
Is there maybe a better way to handle this than simply basing this on whether we are in landscape mode or not?

[ArnyminerZ]

I've simply added a bounding box to all views that makes sure nothing overlays anything:

Accounts screen

Side panel

Webdav mounts

Vertical works correctly as well. Only downside is that content cannot be under the navigation bar, but I guess it's just better to keep it this way.

[sunkup]

When in portrait orientation in the accounts view:

1. turn the device to landscape orientation
2. open the account

Now the space left and right is missing. FABs are under the navigation again. This is probably true for other views as well.

[ArnyminerZ]

Now the space left and right is missing. FABs are under the navigation again. This is probably true for other views as well.

Did you re-build it? I'm not having that issue 🤔

Edit: okay, I guess you used API 34, it's as you've said there.

Intro

Accounts

[ArnyminerZ]

I've now manually configured each activity that required it. I've checked all of them and seem to be fine.

I've also added that when opening the side menu on light mode, the title changes the text color to a lighter one, because otherwise it wasn't visible enough imo.

[mbiebl]

Holy shit, that's a lot of code trying to get this working. Unfortunately, I still find odd issues.

For example if you you turn your phone 90° clockwise (i.e. navigation bar is on the left side)

[sunkup]

I really hope we don't need to add that much code. Can't we turn off edge-to-edge in landscape mode and leave some unused extra whitespace left and right?

Maybe we can schedule a call with the three of us where Arnau explains the situation to us?

@rfc2822 @ArnyminerZ

[ArnyminerZ]

As discussed in the meeting, we'll use safeDrawingPadding with safeDrawingPadding in the AppTheme. Removing all custom paddings.

We'll think about re-implementing edge-to-edge in the future, maybe after #1211, and after completely migrating to Compose Navigation.

[ArnyminerZ]

check whether to add ime padding for all activities not just add webdav add mount

Turns out ime padding was not even necessary, it's already consumed on the theme

[rfc2822]

FAB ist still under phone navigation in landscape orientation and now the app navigation drawer has some extra white space on the wrong side? Right side in the screenshot. What a hard issue 🦖

Can confirm, probably because of the windowInsets = WindowInsets(0.dp) in AccountsScreen.

[ArnyminerZ]

Okay, it should be good now. I've tried every orientation, in both phones and tablets, on API 34 and 35. The only limitation is that API 34 doesn't detect camera cutouts for some reason. But I think we can't do much about it.

[rfc2822]

Doesn't look correct in landscape with 3-button navigation when the navigation drawer is shown:

When nav drawer is not shown, it's OK:

[rfc2822]

I'd say we remove the edge-to-edge from the Accounts drawer as well? So that it's only active for the IntroScreen

[rfc2822]

I have removed edge-to-edge from AccountsScreen and navigation drawer also. Would you like to have a quick check? Otherwise I'd merge it and we can "happily" continue to play around with it later 😄

[ArnyminerZ]

Looks good

[mbiebl]

still looks broken here

[mbiebl]

Notice how the drawer is behind the navigation bar

fixed

[mbiebl]

[mbiebl]

On Android 12 device

Notice how the drawer is visible behind the navigation bar and on the the right side the status bar is not padded and extends all to the right.

[rfc2822]

Notice how the drawer is visible behind the navigation bar and on the the right side the status bar is not padded and extends all to the right.

Could you provide a PR?

Otherwide I'd leave it for now. We don't have resources for that and I don't get it despite investing hours and hours