Skip to content

Conversation

@sunkup
Copy link
Member

@sunkup sunkup commented Jan 14, 2026

Purpose

Updating synctools.

Short description

  • Update synctools to bitfireAT/synctools@9db5cb5
  • Update LocalEvent to use composition over inheritance.
  • Modify LocalCalendar to not use AndroidEventFactory.
  • Adjust ProcessEventsTask to instantiate LocalEvent with AndroidEvent.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

- Update LocalEvent to use composition over inheritance.
- Modify LocalCalendar to not use AndroidEventFactory.
- Adjust ProcessEventsTask to instantiate LocalEvent with AndroidEvent.
@sunkup sunkup self-assigned this Jan 14, 2026
@sunkup sunkup added the refactoring Quality improvement of existing functions label Jan 14, 2026
@sunkup sunkup linked an issue Jan 14, 2026 that may be closed by this pull request
@sunkup sunkup marked this pull request as ready for review January 14, 2026 13:58
@sunkup sunkup requested a review from ArnyminerZ January 14, 2026 13:58
@ArnyminerZ
Copy link
Member

I'm having the same issue locally, I can't build.

@ArnyminerZ
Copy link
Member

I've executed the dependencies insight task, and I got:

androidx.test:rules:1.6.1
  Variant runtime:
    | Attribute Name                                              | Provided     | Requested    |
    |-------------------------------------------------------------|--------------|--------------|
    | org.gradle.libraryelements                                  | jar          |              |
    | org.gradle.status                                           | release      |              |
    | org.gradle.category                                         | library      | library      |
    | org.gradle.usage                                            | java-runtime | java-runtime |
    | com.android.build.api.attributes.AgpVersionAttr             |              | 8.13.2       |
    | com.android.build.api.attributes.BuildTypeAttr              |              | debug        |
    | com.android.build.api.attributes.ProductFlavor:distribution |              | standard     |
    | org.gradle.jvm.environment                                  |              | android      |
    | org.jetbrains.kotlin.platform.type                          |              | androidJvm   |

androidx.test:rules:1.6.1
\--- com.github.bitfireat:synctools:9db5cb5dc6
     \--- standardDebugRuntimeClasspath

So the problem is that synctools is requesting strictly 1.6.1, while we have 1.7.0 in ICSx⁵.

@ArnyminerZ
Copy link
Member

I think the most simply fix would be to downgrade rules and runner to 1.6.1 until we upgrade synctools enough to have 1.7.0

@sunkup sunkup merged commit e364525 into main Jan 28, 2026
5 checks passed
@sunkup sunkup deleted the 785-localevent-dont-subclass-androidevent branch January 28, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalEvent: don't subclass AndroidEvent

2 participants