Skip to content

Filter the Accept-Charset header #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnyminerZ merged 4 commits into from
Jan 28, 2026
Merged

Filter the Accept-Charset header #792

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37033b5
Filter the `Accept-Charset` header
ArnyminerZ Jan 17, 2026
2e9098b
Remove redundant comment
ArnyminerZ Jan 17, 2026
925c3e0
Adds tests
ArnyminerZ Jan 17, 2026
51916a0
Move file
ArnyminerZ Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/src/main/java/at/bitfire/icsdroid/AppHttpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ import io.ktor.client.engine.HttpClientEngine
import io.ktor.client.engine.okhttp.OkHttp
import io.ktor.client.plugins.HttpTimeout
import io.ktor.client.plugins.UserAgent
import io.ktor.client.plugins.api.Send
import io.ktor.client.plugins.api.createClientPlugin
import io.ktor.client.plugins.cookies.HttpCookies
import io.ktor.http.HttpHeaders
import okhttp3.brotli.BrotliInterceptor
import okhttp3.internal.tls.OkHostnameVerifier
import javax.net.ssl.SSLContext
Expand Down Expand Up @@ -85,6 +88,16 @@ class AppHttpClient @AssistedInject constructor(
// Enable cookie storage - in memory, will be lost on app restart
install(HttpCookies)

// Some servers have issues with the Accept-Charset header. It is actually deprecated/not-recommended by RFC 9110 §12.5.2.
// Ktor adds it by default, so we need to manually strip it with a custom plugin.
install(createClientPlugin("RemoveAcceptCharsetHeader") {
on(Send) { request ->
// Remove the header added by Ktor by default because some servers have problems with it
request.headers.remove(HttpHeaders.AcceptCharset)
proceed(request)
}
})

// Disable redirect following, it's handled by CalendarFetcher
followRedirects = false
}
Expand Down