feat: split host api methods to separate out upgrade-script calls #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
changed the title
2 tasks
Julusian
force-pushed
the
feat/parsing-options-in-companion
branch
from
3e3c05c to
dc5e1bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for bitfocus/companion#2345
This might want to be released as 2.0.0 instead of 1.12.0, as ideally modules should be making some changes when updating to this api version.
This is written to support expressions, but we could simply not support them for now. Always set
isExpression: false, so that values are treated as literals.Additionally, companion will need to start parsing any variables in feedback options (doing so reactively), to avoid breaking these feedbacks. I think it should be safe enough if we parse variables for any field which has
useVariables: true.Maybe it should also parse for actions, but that could be too aggressive/higher risk of breakage.
TODO: Should CompanionFeedbackContext.parseVariablesInString become a no-op, as this will be always handled by companion now?
Maybe for actions too?