Skip to content

Conversation

@haakonnessjoen
Copy link
Member

No description provided.

@haakonnessjoen
Copy link
Member Author

When you have time @phillipivan , could you test the tally dump feature again, and show me the debug log. And maybe even take a wireshark capture, so I can double check everything?

That would be super helpful in that case!

@phillipivan
Copy link
Collaborator

Yep, will get to it somewhere in the first half of next week.

@phillipivan
Copy link
Collaborator

Sorry for the delay @haakonnessjoen. Same crash loop, with some more logging.

Let me know if the wireshark trace is important and I will get it installed on that VM if need be.

system: Starting log. Only lines generated since opening the page are shown here
system: Status: connecting - null
system: Status: ok - null
system: Status: ok - Connected
debug: Sending >> 100261019e1003
debug: Sending >> 100264000203971003
debug: Sending >> 100266000203951003
debug: Sending >> 1002150002e91003
debug: Sending >> 1002150102e81003
debug: Sending >> 1002150202e71003
debug: Sending >> 1002150302e61003
debug: Sending >> 1002150402e51003
debug: Sending >> 1002150502e41003
debug: Sending >> 1002150602e31003
debug: Sending >> 1002150702e21003
debug: Sending >> 1002150802e11003
debug: Sending >> 1002150902e01003
debug: Sending >> 1002150a02df1003
debug: Sending >> 1002150b02de1003
debug: Sending >> 1002150c02dd1003
debug: Sending >> 1002150d02dc1003
debug: Sending >> 1002150e02db1003
debug: Sending >> 1002150f02da1003
debug: Sending >> 1002150002e91003
Connected to 172.20.143.75:8910
dest:source feedback 0:2
dest:source feedback 0:3
dest:source feedback 0:4
dest:source feedback 0:5
dest:source feedback 0:6
dest:source feedback 0:7
dest:source feedback 0:8
dest:source feedback 0:9
dest:source feedback 0:10
dest:source feedback 0:1
dest:source feedback 0:32
This router implements: 3,4,11,13,15,23,98,106,107,108,20,122,123,125,131,132,139,141,143,148,151,234,235,236,250,253,1,2,10,12,14,21,97,100,101,102,103,104,105,19,120,121,124,129,130,138,140,142,147,149,228,229,230,231,232,233,248
Reading names
system: ** Connection crashed **
system: ** Connection stopped **
error: node:internal/buffer:88
throw new ERR_OUT_OF_RANGE(type || 'offset',
^

RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 131. Received 133
at boundsError (node:internal/buffer:88:9)
at Buffer.readUInt16BE (node:internal/buffer:334:5)
at SW_P_08.processCrosspointTallyDump (webpack://generic-swp08/./src/crosspoints.js?:107:24)
at SW_P_08.processMessage (webpack://generic-swp08/./src/decode.js?:169:9)
at SW_P_08.decode (webpack://generic-swp08/./src/decode.js?:95:9)
at TCPHelper.eval (webpack://generic-swp08/./src/tcp.js?:212:32)
at TCPHelper.emit (webpack://generic-swp08/./node_modules/eventemitter3/index.js?:181:35)
at Socket.eval (webpack://generic-swp08/./node_modules/@companion-module/base/dist/helpers/tcp.js?:79:48)
at Socket.emit (node:events:524:28)
at addChunk (node:internal/streams/readable:561:12) {
code: 'ERR_OUT_OF_RANGE'
}

Node.js v22.13.1
system: ** Connection stopped **
system: ** Starting Connection from "/home/companion-av/Documents/companion-modules-dev/generic-swp08-2.0.5/main.js" **

@haakonnessjoen
Copy link
Member Author

Thanks for all the info. I think it should work now.

@phillipivan
Copy link
Collaborator

phillipivan commented May 5, 2025

Logs from this mornings testing with tally dump enabled. No crash loop, and it seems to have pulled tallies correctly. One note with the logging, however - our router has 17 levels (video + 16x audio), and the logs mention level 1 and the start and end - should the last one be for level 17 not level 1?

system,Status: connecting - null
console,"Connected to xxx.xxx.xxx.xxx:8910
"
system,Status: ok - null
system,Status: ok - Connected
debug,Sending >> 100261019e1003
console,"This router implements: 3,4,11,13,15,23,98,106,107,108,20,122,123,125,131,132,139,141,143,148,151,234,235,236,250,253,1,2,10,12,14,21,97,100,101,102,103,104,105,19,120,121,124,129,130,138,140,142,147,149,228,229,230,231,232,233,248
"
console,"Reading names
"
debug,Sending >> 100264000203971003
debug,Sending >> 100266000203951003
debug,Sending >> 1002150002e91003
debug,Sending >> 1002150102e81003
debug,Sending >> 1002150202e71003
debug,Sending >> 1002150302e61003
debug,Sending >> 1002150402e51003
debug,Sending >> 1002150502e41003
debug,Sending >> 1002150602e31003
debug,Sending >> 1002150702e21003
debug,Sending >> 1002150802e11003
debug,Sending >> 1002150902e01003
debug,Sending >> 1002150a02df1003
debug,Sending >> 1002150b02de1003
debug,Sending >> 1002150c02dd1003
debug,Sending >> 1002150d02dc1003
debug,Sending >> 1002150e02db1003
debug,Sending >> 1002150f02da1003
debug,Sending >> 1002150002e91003
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 2 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 2 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 2 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 2 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 2 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 3 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 3 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 3 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 3 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 3 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 4 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 4 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 4 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 4 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 4 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 5 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 5 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 5 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 5 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 5 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 6 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 6 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 6 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 6 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 6 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 7 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 7 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 7 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 7 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 7 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 8 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 8 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 8 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 8 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 8 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 9 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 9 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 9 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 9 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 9 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 10 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 10 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 10 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 10 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 10 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 11 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 11 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 11 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 11 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 11 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 12 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 12 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 12 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 12 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 12 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 13 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 13 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 13 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 13 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 13 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 14 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 14 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 14 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 14 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 14 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 15 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 15 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 15 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 15 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 15 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 16 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 16 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 16 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 16 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 16 are going to read 26 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 64 tallies
debug,Crosspoint tally dump for matrix 1 level 1 are going to read 26 tallies
debug,Sending >> 10020001ff1003
debug,Sending >> 10020001ff1003
debug,Sending >> 10020001ff1003
debug,Sending >> 10020001ff1003

…nses, remove "self" usage, added extra caching of variables so we don't update more variables than needed. Don't push variable definitions unless they have changed. Handle "supported commands" data from device better. Cleaned up the way functions are added to the main class.
@haakonnessjoen
Copy link
Member Author

@phillipivan can you test this version? if you enable variables, it should create variables like "route_{level}_{destination}"

@phillipivan
Copy link
Collaborator

@haakonnessjoen yep, I should be able to test this on Friday.

Just a thought, for a large router, that quantity of variables could easily exceed 10k, if they are all auto created on init (I haven't looked at your implementation yet). Prior experience says this would be at risk of grinding the front end to a miserable halt.

@haakonnessjoen
Copy link
Member Author

Yes, thats why the option says "Should only be enabled if you need them specifically.", but maybe we could make it more clear that it is cpu intensive. In buttons this isn't a issue, and will greatly improve the XY routing system.

@phillipivan
Copy link
Collaborator

Sorry, I got busy/forgot to do this today. I'll try and do it Monday, but feel free to ping me a reminder on slack.

@phillipivan
Copy link
Collaborator

@haakonnessjoen this seems to work ok, but I havent done much in the way of specific tests, other than loading the new build in and checking that everything looks ok. If there are specific things you want me to test, let me know. Logs attached.

module-log-02_06_2025-1_36_38 pm.csv

@phillipivan
Copy link
Collaborator

Well I'd note that the selectLevels action only displays a multidropdown with 16 levels even when 17 are set in the config. Though this issue probably predates this PR.
image
image

@haakonnessjoen haakonnessjoen merged commit 921f55f into main Jun 16, 2025
2 checks passed
@haakonnessjoen haakonnessjoen deleted the feat/tally-dump branch June 16, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants