-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open for testing the tally-dump feature added by a85d9d4 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When you have time @phillipivan , could you test the tally dump feature again, and show me the debug log. And maybe even take a wireshark capture, so I can double check everything? That would be super helpful in that case! |
|
Yep, will get to it somewhere in the first half of next week. |
|
Sorry for the delay @haakonnessjoen. Same crash loop, with some more logging. Let me know if the wireshark trace is important and I will get it installed on that VM if need be.
|
|
Thanks for all the info. I think it should work now. |
|
Logs from this mornings testing with |
…nses, remove "self" usage, added extra caching of variables so we don't update more variables than needed. Don't push variable definitions unless they have changed. Handle "supported commands" data from device better. Cleaned up the way functions are added to the main class.
|
@phillipivan can you test this version? if you enable variables, it should create variables like "route_{level}_{destination}" |
|
@haakonnessjoen yep, I should be able to test this on Friday. Just a thought, for a large router, that quantity of variables could easily exceed 10k, if they are all auto created on init (I haven't looked at your implementation yet). Prior experience says this would be at risk of grinding the front end to a miserable halt. |
|
Yes, thats why the option says "Should only be enabled if you need them specifically.", but maybe we could make it more clear that it is cpu intensive. In buttons this isn't a issue, and will greatly improve the XY routing system. |
…ource/dest count to same throttling
|
Sorry, I got busy/forgot to do this today. I'll try and do it Monday, but feel free to ping me a reminder on slack. |
|
@haakonnessjoen this seems to work ok, but I havent done much in the way of specific tests, other than loading the new build in and checking that everything looks ok. If there are specific things you want me to test, let me know. Logs attached. |
…esent the current config settings


No description provided.