fix: (issue 101) presets updated for 5.x with full-sized icons, font sizing auto #106
fix: (issue 101) presets updated for 5.x with full-sized icons, font sizing auto #106nadoubleyou wants to merge 3 commits into
Conversation
|
Thanks for the updated icons! Just a note: the iconpack ZIP is only a convenience archive for end users who want a copy of the preset images because Companion didn’t allow users to save them from the presets/buttons), so there’s no need to include the base64-encoded versions there - as users won't need or understand those. Were you also planning to update the embedded base64 images in presets.ts to use these new icons? I’m happy to do that myself if you weren’t intending to—I just wasn’t sure what your plan was. If you do update them, could you please wrap the base64 strings at 100 characters per line using a trailing \ line continuation? For example:
|
|
I Just realized that as I was looking through the help.md file... |
|
Also the text size is of all presets (14pt) - is not working in Companion 5.* Companion 5 changed fonts to be more flexible and expresses size differently (percentage of element rather than fixed point size). I dont know for sure, but I expected the upgrade would have mapped the old presets from using points to the new method in a way that keeps them looking the same. This has not worked either. The text is a lot larger and overflows. For now, I think we can easily use auto sizing by replacing |
|
I think I got everything. Looks pretty good on 5, although there's occasionally the issue with the auto font size wrapping a single letter to the next line. But Companion has done that for a long time, at least in my experience (since v2.x). What do you think about pushing the icons to the top or bottom of the buttons? If the newlines weren't necessary it would make things more predictable a fixed font size. I might test that out. You mentioned reworking the "doco" I'm assuming that's the help.md? |

Padded all icons to 72x72, included .txt files with base64 encoding. Archive includes original PNG, padded PNG & base64 .txt files.