-
-
Notifications
You must be signed in to change notification settings - Fork 520
feat: Add generic length function, closes #3308 #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
355661d
feat: Add array length function, closes #3308
peternewman b87f922
Try and switch to new behaviour
peternewman 7eecaef
Handle undefined variables in length function
peternewman b8c20ba
Add some JSON tests to the length function too
peternewman c4c333b
Handle objects within length function too
peternewman f00633c
chore: Fix prettier
peternewman d6b668f
chore: Add a decimal value and a negative number to the length tests
peternewman e8e43cf
Fix @dnmeid's comments/suggestions and add more tests
peternewman 4babc0b
Handle RegExp and prettier format
peternewman 89d945a
chore: Try and fix the RegExp test
peternewman c1d2435
Fix some of the simpler edge case behaviour
peternewman c5425bd
Properly count UTF graphemes too
peternewman 983f997
Add missing entry to yarn.lock
peternewman ac650f2
Merge branch 'main' into peternewman-array-length
peternewman 2e32088
chore: Prettier
peternewman 4f3acb5
Unicode tests and grapheme orders for length function
peternewman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.