chore: ignore additional directories to avoid maxing out watched files#4327
chore: ignore additional directories to avoid maxing out watched files#4327bryce-seifert wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughDevelopment watchers now share centralized ignored-directory and watched-extension rules. The main watcher observes narrower artifact and documentation paths, while launcher and extra-module watchers use the shared ignore predicate. ChangesDevelopment watcher filtering
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I will look at this, but an idea I have been wondering about recently is maybe trying to ditch the That would mean being able to stop the But this likely requires some tweaks to many build things to get it all happy (keeping shared-lib importable could be interesting) Feel free to look into this, or I can look at this PR as it stands, Im happy either way |
Alternative approach from #4240
In my testing being more restrictive on the ignored directories has fixed up the EMFILE watcher errors with large amount of modules, while keeping chokidar in place.
Summary by CodeRabbit