-
Notifications
You must be signed in to change notification settings - Fork 68
Upgrade to ESP-IDF v5.4 for Arduino IDE and PlatformIO #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PIBSAS
wants to merge
11
commits into
bitluni:master
Choose a base branch
from
PIBSAS:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino Platform: Upgrade to Arduino 3.2.0 based on ESP-IDF v5.4 Board Manager -> esp32 by Espressif Systems version 3.2.0 GitHub: https://github.com/espressif/arduino-esp32/releases Platformio: VsCode withh Platformio for Espressif 32 Dev Module Version 6.10.0 based on ESP-IDF v5.4. Board -> Espressif 32 Dev Module Platform -> Espressif 32 Version 6.10.0 GitHub: https://github.com/platformio/platform-espressif32/releases Changes on files: On CompositeGraphics.h #include <algorithm> 68 void print(char *str) -> void print(const char *str) [char -> const char] 129 backbuffer[y][x] = min(54, color + backbuffer[y][x]); -> backbuffer[y][x] = std::min(54, color + backbuffer[y][x]); [min() -> std:min()]
Arduino Platform: Upgrade to Arduino 3.2.0 based on ESP-IDF v5.4 Board Manager -> esp32 by Espressif Systems version 3.2.0 GitHub: https://github.com/espressif/arduino-esp32/releases Platformio: VsCode withh Platformio for Espressif 32 Dev Module Version 6.10.0 based on ESP-IDF v5.4. Board -> Espressif 32 Dev Module Platform -> Espressif 32 Version 6.10.0 GitHub: https://github.com/platformio/platform-espressif32/releases Changes on file: On CompositeOutput.h: After Line 2 add: #include "soc/i2s_reg.h" 166 .communication_format = I2S_COMM_FORMAT_I2S_MSB -> I2S_COMM_FORMAT_STAND_I2S,
…or PlatformIO #ifdef PLATFORMIO #include <Arduino.h> #endif
…or PlatformIO #ifdef ARDUINO #include <Arduino.h> #endif
#ifdef ARDUINO #include <Arduino.h> #endif
On Mesh.h After line 2 add: #include <algorithm> 68 const float NdotL = max(0.0f, nx * L[0] + ny * L[1] + nz * L[2]); -> const float NdotL = std::max(0.0f, nx * L[0] + ny * L[1] + nz * L[2]); [max() -> std::max()]
remove directive, wrong file example
Arduino Platform: Upgrade to Arduino 3.2.0 based on ESP-IDF v5.4 Board Manager -> esp32 by Espressif Systems version 3.2.0 GitHub: https://github.com/espressif/arduino-esp32/releases Platformio: VsCode withh Platformio for Espressif 32 Dev Module Version 6.10.0 based on ESP-IDF v5.4. Board -> Espressif 32 Dev Module Platform -> Espressif 32 Version 6.10.0 GitHub: https://github.com/platformio/platform-espressif32/releases Changes on file: On CompositeGraphics.h After line 3 add: #include <algorithm> 68 void print(char *str) -> void print(const char *str) [char -> const char] 129 backbuffer[y][x] = min(54, color + backbuffer[y][x]); -> backbuffer[y][x] = std::min(54, color + backbuffer[y][x]); [min() -> std:min()]
Arduino Platform: Upgrade to Arduino 3.2.0 based on ESP-IDF v5.4 Board Manager -> esp32 by Espressif Systems version 3.2.0 GitHub: https://github.com/espressif/arduino-esp32/releases Platformio: VsCode withh Platformio for Espressif 32 Dev Module Version 6.10.0 based on ESP-IDF v5.4. Board -> Espressif 32 Dev Module Platform -> Espressif 32 Version 6.10.0 GitHub: https://github.com/platformio/platform-espressif32/releases Changes on file: On CompositeOutput.h: After Line 2 add: #include "soc/i2s_reg.h" 166 .communication_format = I2S_COMM_FORMAT_I2S_MSB -> I2S_COMM_FORMAT_STAND_I2S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to ESP-IDF v5.4:
Arduino Platform:
Platformio:
Example CompositeVideoSimple
Changes on files:
CompositeGraphics.h
:After line 3 add:
#include <algorithm>
68
void print(char *str)
->void print(const char *str)
[char -> const char].129
backbuffer[y][x] = min(54, color + backbuffer[y][x]);
->backbuffer[y][x] = std::min(54, color + backbuffer[y][x]);
[min() -> std:min()].CompositeOutput.h
:After Line 2 add:
#include "soc/i2s_reg.h"
166
.communication_format = I2S_COMM_FORMAT_I2S_MSB
->.communication_format = I2S_COMM_FORMAT_STAND_I2S
[I2S_COMM_FORMAT_I2S_MSB -> I2S_COMM_FORMAT_STAND_I2S]Example CompositeVideo.
Changes on files:
CompositeVideo.ino
This is for PlatformIO compability.After line 1 add:
Mesh.h
After line 2 add:
#include <algorithm>
68
const float NdotL = max(0.0f, nx * L[0] + ny * L[1] + nz * L[2]);
->const float NdotL = std::max(0.0f, nx * L[0] + ny * L[1] + nz * L[2]);
[max() -> std::max()]CompositeGraphics.h
:After line 3 add:
#include <algorithm>
68
void print(char *str)
->void print(const char *str)
[char -> const char].129
backbuffer[y][x] = min(54, color + backbuffer[y][x]);
->backbuffer[y][x] = std::min(54, color + backbuffer[y][x]);
[min() -> std:min()].CompositeOutput.h
:After Line 2 add:
#include "soc/i2s_reg.h"
166
.communication_format = I2S_COMM_FORMAT_I2S_MSB
->.communication_format = I2S_COMM_FORMAT_STAND_I2S
[I2S_COMM_FORMAT_I2S_MSB -> I2S_COMM_FORMAT_STAND_I2S]