-
-
Notifications
You must be signed in to change notification settings - Fork 188
qbittorrent and transmission as clients of bitmagnet #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…l mutation integration. webui is not included as that is subject to change, code is available
|
Tested multiple content types - expected restricted categories work as expected in transmission and qbittorrent |
…l mutation integration. webui is not included as that is subject to change, code is available
translations with npx i18n-auto-translation -k $API_KEY -d webui/src/app/i18n/translations -t
|
Taskfile.yml
Outdated
| "uk", | ||
| "zh", | ||
| ] | ||
| cmd: npx i18n-auto-translation -k $API_KEY -d webui/src/app/i18n/translations -t {{ .ITEM }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how the changes in this file are relevant to the pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops ;-) leakage of command I use to populate i18n translations. removed.
internal/client/config.go
Outdated
| type Config struct { | ||
| Enabled bool | ||
| Transmission DownloadClient | ||
| Qbittorrent DownloadClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer a "send to [target]" model with any number of configurable targets possible instead of just 2 hard coded clients.
The "target" wouldn't even have to be a BT client and would allow for more flexibility especially once plugins are possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've reworked to "send to [target]" model. Configuration now uses slices config capability then you developed for Torznab profiles
- clearly there is still some static coding. Notably the qbittorrent and transmission implementations of interface. Plus switch statement to select struct that implements interface.
- to add another send to target
- update graphql enum. regen generated go and typescript code
- implement interface
- extend switch
|
I realised there was an issue with enums. Example config section for reference: |
Includes graphql mutation integration. webui is not included as that is subject to change, code is available
Implements interfaces and design constraints noted in issue #300