Use pointer to StableBloomFilter#446
Open
netheril96 wants to merge 1 commit into
Open
Conversation
The value copy may be bugged in certain situations
giorgiobrullo
added a commit
to giorgiobrullo/bitmagnet
that referenced
this pull request
Mar 1, 2026
Cherry-pick of PR bitmagnet-io#446. Value-copy of boom.StableBloomFilter caused occasional nil pointer dereference. Using a pointer embedding instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mdalsi
added a commit
to mdalsi/bitmagnet
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a nil pointer exception in the bloom filter and it looked like copying
boom.StableBloomFilterby value may not be safe. This PR changes it to a pointer so it is guaranteed to be initialized correctly. The nil pointer exception has since gone away for me.