Skip to content

Fix spiders data loading in job details #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquingx merged 2 commits into from
Mar 24, 2026
Merged

Fix spiders data loading in job details #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b153f
fix spiders data loading in job details
erick-GeGe Nov 6, 2025
2d3eb85
add delay to spiders loading
erick-GeGe Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions estela-web/src/pages/JobDetailPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,11 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
resourceNotAllowedNotification();
},
);
this.getProjectSpiders();
await this.getItems(1);
this.setState({ loadedItemsFirstTime: true });
setTimeout(() => {
this.getProjectSpiders();
}, 500);
}

getProjectSpiders = async (): Promise<void> => {
Expand Down Expand Up @@ -907,7 +909,7 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
} = this.state;
return (
<Content className="content-padding">
{loaded && loadedSpiders ? (
{loaded ? (
<Layout className="white-background">
<Content className="bg-metal rounded-2xl">
<Row className="flow-root lg:mt-10 lg:mx-10 mt-6 mx-6">
Expand All @@ -923,11 +925,13 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
modalClone: true,
});
}}
icon={<Copy className="h-6 w-6 mr-2 text-sm" />}
loading={!loadedSpiders}
disabled={!loadedSpiders}
icon={!loadedSpiders ? null : <Copy className="h-6 w-6 mr-2 text-sm" />}
size="large"
className="flex items-center stroke-white border-estela hover:stroke-estela bg-estela text-white hover:text-estela text-sm hover:border-estela rounded-md"
>
Clone this job
{!loadedSpiders ? "Loading..." : "Clone this job"}
</Button>
<Button
disabled={!(status == SpiderJobUpdateStatusEnum.Running)}
Expand Down
Loading