Skip to content

[bitnami/elasticsearch] remove copyTlsCerts init container #31960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ianroberts
Copy link

@ianroberts ianroberts commented Feb 17, 2025

Description of the change

Remove the initContainer that copies TLS certificates from the secret to the emptyDir volume and revert to mounting the secret directly into the various statefulset pods.

Benefits

Fixes #31872, renewed TLS certificates will be automatically reloaded by the various pods.

Possible drawbacks

The initContainer was initially introduced as a way to work around errors that occurred when running the Elasticsearch container as root (see #25280). This PR will revert to the previous behaviour that broke that use case, but I believe the right place to fix that problem is in the container image, not in the chart, and I have submitted bitnami/containers#77525 to that effect.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
    • I have removed a number of variables from values.yaml and from the README, nothing has been added
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@ianroberts
Copy link
Author

ianroberts commented Feb 17, 2025

It probably makes sense to fix bitnami/containers#77525 first, then update the image version in this PR's values.yaml before merging.

Edit: PR bitnami/containers#77526 submitted

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Feb 18, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 18, 2025
@github-actions github-actions bot removed the request for review from carrodher February 18, 2025 08:57
@github-actions github-actions bot requested a review from gongomgra February 18, 2025 08:57
@carrodher carrodher requested review from migruiz4 and removed request for gongomgra February 18, 2025 08:57
@carrodher carrodher assigned migruiz4 and unassigned gongomgra Feb 18, 2025
Copy link

github-actions bot commented Mar 6, 2025

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Mar 6, 2025
@ianroberts
Copy link
Author

Not stale, but waiting on bitnami/containers#77526

@github-actions github-actions bot removed the stale 15 days without activity label Mar 7, 2025
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Mar 22, 2025
@ianroberts
Copy link
Author

Not stale but still blocked waiting for bitnami/containers#77526 - I will rebase once this is merged and a fixed container image is released.

@github-actions github-actions bot removed the stale 15 days without activity label Mar 23, 2025
@ianroberts
Copy link
Author

Rebased, but still needs @migruiz4 to approve the underlying containers fix before it makes sense to merge this one.

Remove the initContainer that copies TLS certificates from the secret to the emptyDir volume and revert to mounting the secret directly into the various statefulset pods.  This fixes bitnami#31872, but will break bitnami#25280 until bitnami/containers#77525 is fixed

Signed-off-by: Ian Roberts <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Apr 11, 2025
@ianroberts
Copy link
Author

Not stale, but still waiting on approval of bitnami/containers#77526

@github-actions github-actions bot removed the stale 15 days without activity label Apr 12, 2025
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Apr 27, 2025
@ianroberts
Copy link
Author

Not stale, but still waiting on approval of bitnami/containers#77526

@github-actions github-actions bot removed the stale 15 days without activity label Apr 28, 2025
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label May 13, 2025
@ianroberts
Copy link
Author

Still waiting on containers fix.

@github-actions github-actions bot removed the stale 15 days without activity label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elasticsearch in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/elasticsearch] renewed TLS certificates no longer auto-reloading
5 participants