-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[bitnami/elasticsearch] remove copyTlsCerts init container #31960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It probably makes sense to fix bitnami/containers#77525 first, then update the image version in this PR's Edit: PR bitnami/containers#77526 submitted |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Not stale, but waiting on bitnami/containers#77526 |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Not stale but still blocked waiting for bitnami/containers#77526 - I will rebase once this is merged and a fixed container image is released. |
4371287
to
b60c2db
Compare
Rebased, but still needs @migruiz4 to approve the underlying containers fix before it makes sense to merge this one. |
Remove the initContainer that copies TLS certificates from the secret to the emptyDir volume and revert to mounting the secret directly into the various statefulset pods. This fixes bitnami#31872, but will break bitnami#25280 until bitnami/containers#77525 is fixed Signed-off-by: Ian Roberts <[email protected]>
b60c2db
to
1b751ea
Compare
Signed-off-by: Bitnami Bot <[email protected]>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Not stale, but still waiting on approval of bitnami/containers#77526 |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Not stale, but still waiting on approval of bitnami/containers#77526 |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Still waiting on containers fix. |
Description of the change
Remove the initContainer that copies TLS certificates from the secret to the emptyDir volume and revert to mounting the secret directly into the various statefulset pods.
Benefits
Fixes #31872, renewed TLS certificates will be automatically reloaded by the various pods.
Possible drawbacks
The initContainer was initially introduced as a way to work around errors that occurred when running the Elasticsearch container as root (see #25280). This PR will revert to the previous behaviour that broke that use case, but I believe the right place to fix that problem is in the container image, not in the chart, and I have submitted bitnami/containers#77525 to that effect.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm