[bitnami/valkey-cluster] Add support for templating nodes, replicas, resources, and persistent storage values

[mbrancato]

Description of the change

This PR adds support to template the values input for the nodes, replicas, resources, and persistent storage of a cluster.

Benefits

Currently, this helm chart does not allow configuration by shard. This PR allows for abstraction when used as a subchart, or when the user just wants to configure things differently.

For example, this abstraction becomes possible:

global:
  cache:
    shards: 18
    replicas: 3

cluster:
  nodes: "{{ .Values.global.cache.shards | int | mul .Values.global.cache.replicas | int }}"
  replicas: "{{ .Values.global.cache.replicas }}"

Possible drawbacks

This should be compatible with all existing usage.

Additional information

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[migruiz4]

Hi @mbrancato,

Thank you very much for your contribution! Could you please take a look at my comment?

[migruiz4]

I'm sorry but I'm not understanding, why the typeOf is required? Can't this be simplified like this?

Suggested change

	replicas: {{ if eq (typeOf .Values.cluster.nodes) "float64" -}}{{ .Values.cluster.nodes }}{{- else -}}{{ tpl .Values.cluster.nodes . | int }}{{- end }}
	replicas: {{ tpl .Values.cluster.nodes . | int }}

For those values that need to be quoted, like environment variables values: {{ tpl .Values.cluster.nodes $ | int | quote }}

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.