Skip to content

[bitnami/superset] fix ingress with extraHosts failed to deploy #33052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[bitnami/superset] fix ingress with extraHosts failed to deploy #33052

wants to merge 2 commits into from

Conversation

moonlight8978
Copy link

Description of the change

The current . is the host iterator object (range .Values.ingress.extraHosts), it made include "common.names.fullname" . failed to evaluate, so we need to assign . to $root before looping extraHosts

Benefits

User can install bitnami/superset with ingress.extraHosts

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added superset triage Triage is needed labels Apr 17, 2025
@github-actions github-actions bot requested a review from javsalgar April 17, 2025 02:49
@bitnami-bot
Update CHANGELOG.md
27188f3 
Signed-off-by: Bitnami Bot <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 17, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 17, 2025
@github-actions github-actions bot removed the request for review from javsalgar April 17, 2025 07:33
@github-actions github-actions bot requested a review from jotamartos April 17, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos Awaiting requested review from jotamartos

At least 1 approving review is required to merge this pull request.

Assignees

@jotamartos jotamartos

Labels
in-progress superset verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/superset] Fresh installation failed when using ingress.extraHosts
5 participants
@moonlight8978 @javsalgar @jotamartos @carrodher @bitnami-bot