Fix keyring copy on Debian 13/trixie #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems as though the `/usr/share/keyrings/debian-archive-keyring.gpg`
on Debian 13/trixie is actually a symlink to
`debian-archive-keyring.pgp` in the same directory. This means that the
`cp -a` in `mkimage` copies the symlink and not the actual keyring,
resulting in the following error:
E: specified keyring file (/<tmpdir>/debian-archive-keyring.gpg) not found
Using `cp -aL` ensures the file that is symlink source actually gets
copied.
Signed-off-by: John Kristensen <[email protected]>
jerrykan
force-pushed
the
debian13_fix
branch
from
e29f6a7 to
79d3eb7
Compare
Contributor
Author
|
Added the missing |
jotamartos
approved these changes
Dec 16, 2025
Contributor
jotamartos
left a comment
jotamartos
left a comment
There was a problem hiding this comment.
Change LGTM. Thank you for your contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix running
mkimageon Debian 13/trixieBenefits
The
mkimagescript will run on Debian 13/trixiePossible drawbacks
None
Applicable issues
None
Additional information
It seems as though the
/usr/share/keyrings/debian-archive-keyring.gpgon Debian 13/trixie is actually a symlink todebian-archive-keyring.pgpin the same directory. This means that thecp -ainmkimagecopies the symlink and not the actual keyring, resulting in the following error:Using
cp -aLensures the file that is symlink source actually gets copied.