Update pattern for FullyQualifiedReference in schema

[FriedrichBu]

YAML-Files not only have the filename extension .yaml, but also .yml. Thus, it'd make sense to include .yml as valid filename extention as well in the reference schema.

[pflooky]

Hey @FriedrichBu , thanks for raising the PR. Looks like we could put this into a patch release of ODCS. Can you make the PR to dev branch instead?

[pflooky]

This also perhaps raises another question about whether we want to restrict file name extensions to also include .odcs.yaml or .odcs.yml. We have these two extensions defined within schema store as seen here: https://github.com/SchemaStore/schemastore/blob/master/src/api/json/catalog.json#L4487

[jgperrin]

I am definitely not the person to review regex ;)

[dccakes]

Agree on adding yml | yaml to the schema as a patch.

[FriedrichBu]

Hi @pflooky,
thanks for the positive feedback. I have changed the PR to the dev branch.

[FriedrichBu]

@pflooky, I have been thinking about ocds.yml and ocds.yaml.

We can add (?:\.ocds)? (equals an optional .ocds) before \.ya?ml. However, in the string part before \.ya?ml anyways . and A-Za-z are allowed ([A-Za-z0-9._\\-\\/]), which already allows .ocds, but also others like .extra.yaml or .other.yml.
I am not sure, but I think it would be necessary to disallow any further . in the base filename apart from those in .ocds and .yaml. Is that desirable?

If yes, a bigger change would be required to split the variants that are possible before .yml and .yaml:

• Same folder as current contract: data-contract-v1.yaml#/schema
• Full path: file:///path/to/data-contract-v1.yaml#/schema
• URL: https://example.com/data-contract-v1.yaml#/schema
• Relative path: ../../path/to/data-contract-v1.yaml#/schema

to enable . only in case of URL for subdomain.domain.

[FriedrichBu]

I further noticed that from external references:

file:///path/to/data-contract-v1.yaml

is currently not allowed by the pattern.
(?:https?:\\/\\/)? should be extended to (?:https?:\\/\\/|file:\\/\\/\\/)? to enable file:///

So in total: "^(?:(?:https?:\\/\\/|file:\\/\\/\\/)?[A-Za-z0-9._\\-\\/]+(?:\\.ocds)?\\.ya?ml#)?\\/?[A-Za-z_][A-Za-z0-9_]*\\/[A-Za-z0-9_-]+(?:\\/[A-Za-z_][A-Za-z0-9_]*\\/[A-Za-z0-9_-]+)*$

With distunigshing .ocds as suggested as option above: ^(?:(?:https?:\\/\\/[A-Za-z0-9._\\-]+(?::\d+)?|file:\\/\\/\\/|(?:\.{1,2}[\\/])+)?(?:[A-Za-z0-9._\\-]+[\\/])*?([A-Za-z0-9_\\-]+)?(?:\\.ocds)?\\.ya?ml#)?\\/?[A-Za-z_][A-Za-z0-9_]*\\/[A-Za-z0-9_-]+(?:\\/[A-Za-z_][A-Za-z0-9_]*\\/[A-Za-z0-9_-]+)*$

[jgperrin]

Can we merge or close this one?