Allow dashes in ShorthandReference#260
Open
ed-fbiberger wants to merge 3 commits intobitol-io:devfrom
Open
Conversation
simonharrer
reviewed
Apr 21, 2026
| "type": "string", | ||
| "description": "Shorthand notation using name fields (table_name.column_name)", | ||
| "pattern": "^[A-Za-z_][A-Za-z0-9_]*(\\.[A-Za-z_][A-Za-z0-9_]*)+$" | ||
| "pattern": "^[A-Za-z_][A-Za-z0-9_\\-]*(\\.[A-Za-z_][A-Za-z0-9_\\-]*)+$" |
Contributor
There was a problem hiding this comment.
Is the escape character necessary for dashes in regex?
Contributor
Author
There was a problem hiding this comment.
Nope, but I find it easier to read, as the dash is also used with semantical meaning in ranges e.g. a-z. I found both usages in ODCS schema and decided to use it with escape char, but can easily be changed.
ed-fbiberger
force-pushed
the
fix-shorthand-reference-dashes
branch
from
142f273 to
9063bfa
Compare
Contributor
Author
|
Added an example that checks, if shorthand references are usable with dashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
we recognised that the regular expressions for
ShorthandReferenceis too restrictive.At the moment it does not allow
-as character being used. As table names for some technologies sometimes can contain this character, it breaks contract validation in those cases. E.g.is not possible with the current regex:
I updated this to:
so that table names with dashes are supported.