Fix ECR code

[LeoDiazL]

• ECR Code was missing in commons.
• Made proxy env file dependent of proxy creation

[mickmcgrath13]

i skimmed and had copilot review as well. lgtm

---

Copilot's response:

Code Review Summary:

1. File: generate_bitops_config.sh

   • Changes:
     • Added support for AWS_ECR_REPO_CREATE in multiple conditional checks.
     • Removed redundant conditional blocks for AWS_ECR_REPO_CREATE.
   • Review:
     • The addition of AWS_ECR_REPO_CREATE in the conditional checks aligns with the existing pattern.
     • Removal of redundant conditions helps streamline the script.
     • Ensure that AWS_ECR_REPO_CREATE is properly defined and documented in the environment setup.

2. File: generate_provider.sh

   • Changes:
     • Modified the generate_provider_aws call to include ecr.
     • Removed commented-out calls for ecr and eks.
   • Review:
     • Including ecr in the generate_provider_aws call ensures that it is consistently managed with other AWS services.
     • Cleaning up commented-out code improves readability and maintenance.
     • Verify that the generate_provider_aws function correctly handles the new ecr inclusion without issues.

Additional Notes:

• Removed Files:
  • Several Terraform and shell script files related to ecr were removed.
  • Ensure that the removal does not affect any existing deployments or configurations.
• Terraform Configuration Updates:
  • Adjustments in aws/bitovi_main.tf re-enable the aws_ecr module and add conditional logic for its output.
  • Ensure that these configurations are tested in a staging environment before applying them to production.

Overall, the changes aim to integrate AWS_ECR_REPO_CREATE into the existing infrastructure scripts while removing redundant or outdated code. Proper testing and validation are recommended to ensure smooth integration.