Fix JMVC 3.2 shims in jquerypp/model/list
#104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the
jquerypp/model/list
module contains some shims that maintain backwards-compatibility with JavascriptMVC 3.2 code. Unfortunately, the shims were broken because their "results" were unused.We fixed these, and added tests to prove the failures, and cover the fixed usages.
This helps developers who are updating a project version from pre-3.3 - less code to have to fix.