Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JMVC 3.2 shims in jquerypp/model/list #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

asavoy
Copy link
Contributor

@asavoy asavoy commented Oct 21, 2013

We found that the jquerypp/model/list module contains some shims that maintain backwards-compatibility with JavascriptMVC 3.2 code. Unfortunately, the shims were broken because their "results" were unused.

We fixed these, and added tests to prove the failures, and cover the fixed usages.

This helps developers who are updating a project version from pre-3.3 - less code to have to fix.

@asavoy
Copy link
Contributor Author

asavoy commented Dec 20, 2013

Would be great to get some feedback on this pull request! :)

It's fixing backwards compatibility for projects migrating from JavascriptMVC 3.2 - the code that is affected looks like it tries to achieve this, but just falls short.

@amelon
Copy link

amelon commented Jan 6, 2014

project still alive?

@alexisabril
Copy link
Contributor

Project's still alive, however this particular issue warrants a bit of discussion. jQuery++'s primary goal is to fill the gaps that jQuery itself has at the moment. However, due to our migration in JMVC, a few JMVC bits live in this project(model/list being one of them). Some of the discussion rests around how to migrate the MVC bits out of jQuery++, as only JMVC users utilize those pieces.

@justinbmeyer
Copy link
Member

jQuery++ is alive, but we're no longer working on its backwards compatible shims.

Sent from my iPhone

On Jan 6, 2014, at 7:54 AM, Arnaud [email protected] wrote:

project still alive?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants