Android: unit tests for package install codepaths - #53
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The only unresolved comment is a non-blocking wording nit.
Pull request overview
Adds Android JVM unit coverage for downloaded package installation paths.
Changes:
- Extracts package installation logic for direct testing.
- Tests raw, ZIP, integrity, signature, and differential updates.
- Adds JSON and Mockito test dependencies.
File summaries
| File | Description |
|---|---|
android/app/src/test/java/com/microsoft/codepush/react/CodePushUpdateManagerTest.kt |
Adds installation-path tests. Minor wording nit: change “as long there is” to “as long as there is.” |
android/app/src/main/java/com/microsoft/codepush/react/CodePushUpdateManager.java |
Extracts installation logic into a package-visible method. |
android/app/build.gradle |
Adds required test dependencies. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ofalvai
force-pushed
the
android-existing-package-tests
branch
from
September 4, 2026 07:35
1794c83 to
182cec5
Compare
sajtizsolt
reviewed
Sep 4, 2026
sajtizsolt
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging #42 and #43, it would give us more confidence if the whole package install codepath was covered with tests (E2E tests don't cover every scenario).
Thanks to #38, unit tests are now possible on the Android side.
Changes
Out of scope
I'd like to land this PR first, then rebase #42 and include new test cases for binary diff patching.