Remove dead config, code - #54
Merged
Merged
Conversation
ofalvai
commented
Sep 7, 2026
| STACK TRACE AND/OR SCREENSHOTS | ||
| ``` | ||
|
|
||
| ### Reproducible Demo |
Collaborator
Author
There was a problem hiding this comment.
Hardcodes RN and CodePush SDK versions. I think it adds too much friction, and we are not drowning in user reports at the moment. I'd rather receive an incomplete report and let an LLM try to reproduce it than not receiving that potentially useful report.
ofalvai
commented
Sep 7, 2026
| @@ -1,3 +0,0 @@ | |||
| { | |||
| "typescript.tsdk": "node_modules/typescript/lib" | |||
Collaborator
Author
There was a problem hiding this comment.
Deprecated field, not needed anymore.
ofalvai
commented
Sep 7, 2026
| @@ -1,87 +0,0 @@ | |||
| var linkTools = require('../../tools/linkToolsAndroid'); | |||
ofalvai
commented
Sep 7, 2026
| "url": "https://github.com/bitrise-io/react-native-code-push" | ||
| }, | ||
| "dependencies": { | ||
| "glob": "^7.1.7", |
Collaborator
Author
There was a problem hiding this comment.
These were only used in the postlink scripts
ofalvai
commented
Sep 7, 2026
| "tslint": "^6.1.3", | ||
| "typescript": "^4.4.3" | ||
| }, | ||
| "rnpm": { |
Collaborator
Author
There was a problem hiding this comment.
This is no longer needed and is a dead project: https://github.com/rnpm/rnpm
ofalvai
marked this pull request as ready for review
September 7, 2026 11:36
ofalvai
force-pushed
the
push-skmtntryoyws
branch
from
September 7, 2026 11:37
d852a31 to
efaf814
Compare
sajtizsolt
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See inline comments for details.
Examples/CodePushDemoAppCpp: it's a Windows sample, not kept up to date at all. My AI agents frequently get confused by this sample.