Skip to content

Avoid overflow #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 3 commits into from
Oct 26, 2025
+17 −1
Merged

Avoid overflow #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6f5d9c
in a test, we cause an overflow
lemire Oct 26, 2025
1b6ab8b
adding legacy ci
lemire Oct 26, 2025
475d3e8
removing space
lemire Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/legacy86.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Go-legacy-CI

on: [push, pull_request]

jobs:
test:
runs-on: ubuntu-latest
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v4
- name: Test on 386
run: |
GOARCH=386 go test
Comment on lines +8 to +16

Copilot AI Oct 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is missing the 'steps:' keyword before the step definitions, and the 'strategy.matrix' configuration for the go-version variable referenced on line 11. The workflow should include 'steps:' at line 7 and a strategy matrix defining go-version values.

Suggested change
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v4
- name: Test on 386
run: |
GOARCH=386 go test
strategy:
matrix:
go-version: [ '1.20.x', '1.21.x' ]
steps:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v4
- name: Test on 386
run: |
GOARCH=386 go test

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion bitset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2490,7 +2490,7 @@ func TestWord(t *testing.T) {
expected: 0,
},
"way off the edge": {
index: 6346235235,
index: 63235235,
expected: 0,
},
"split between two words": {
Expand Down
Loading