-
Notifications
You must be signed in to change notification settings - Fork 650
[HARDFORK] Feature/asset disable limit order create flag #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[HARDFORK] Feature/asset disable limit order create flag #1611
Conversation
BSIP: bitshares/bsips#148 As can be seen from the BSIP, an open question is if it makes sense to use a simple binary toggle, or maybe instead introduce another whitelist to the asset. |
Proper procedure is
|
We wanted to shortcut internally and asked our developers to implement this as part of a learning process. It was lying around for many months and I thought we should rather shoot this upstream than forget about it ... Now that we have more structure in place internally, we hope to follow procedure better in the future. Sorry for the inconvenience. |
If going forward with this implementation the code need to be against |
Also, as usual with hardfork changes, need guards to make sure the flag can not be used before date. |
This pull request introduces code that allows to set a new flag for an asset. This flag
only_issuer_limit_orders_allowed 0x200
can be used to prevent other market participants from placing orders in the market. The feature is particularly useful in case of an ICO with multiple stages where only the issue should be able to sell tokens and prevent previous participants from making instant profits.A corresponding BSIP will follow
(paging @Dimfred)