Skip to content

Arch/client crate - #19

Draft
MGibson1 wants to merge 3 commits into
mainfrom
arch/client-crate
Draft

Arch/client crate#19
MGibson1 wants to merge 3 commits into
mainfrom
arch/client-crate

Conversation

@MGibson1

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38301

📔 Objective

Creates an AKD-watch client for use in client-side verification of akd proofs

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.45025% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.76%. Comparing base (a67678d) to head (32e705b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/web-client/src/client.rs 61.63% 61 Missing ⚠️
crates/protocol/src/web_api.rs 78.94% 24 Missing ⚠️
crates/protocol/src/lib.rs 90.85% 16 Missing ⚠️
crates/web-client/src/keys.rs 92.30% 4 Missing ⚠️
crates/web-client/src/wire.rs 0.00% 3 Missing ⚠️
crates/web-client/src/verify.rs 97.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   52.97%   56.76%   +3.79%     
==========================================
  Files          40       46       +6     
  Lines        3028     3405     +377     
==========================================
+ Hits         1604     1933     +329     
- Misses       1424     1472      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MGibson1 MGibson1 added the ai-review Request a Claude code review label May 28, 2026
@theMickster theMickster added ai-review Request a Claude code review and removed ai-review Request a Claude code review ai-review-vnext labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants