Skip to content

Explore responsive account settings #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jul 15, 2024

🎟️ Tracking

📔 Objective

Explore responsive account settings.

This solution uses a custom tailwind plugin which can be used by prefixing media queries with @. For @md:tw-grid-cols-2 it generates the following code:

@media (min-width: 768px) {
    .\@md\:tw-grid-cols-2 {
        grid-template-columns: repeat(2, minmax(0, 1fr));
    }
}
html.tw-fixed-width .\@md\:tw-grid-cols-2 {
    grid-template-columns: repeat(2, minmax(0, 1fr));
}

Which essentially applies all media queries on the fixed width.

📸 Screenshots

Screen.Recording.2024-07-15.at.18.24.02.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (7eaf870) to head (a272452).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/layouts/toggle-width.component.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10121      +/-   ##
==========================================
+ Coverage   33.04%   33.06%   +0.01%     
==========================================
  Files        2680     2680              
  Lines       83332    83361      +29     
  Branches    15844    15848       +4     
==========================================
+ Hits        27540    27562      +22     
- Misses      53615    53620       +5     
- Partials     2177     2179       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Logo
Checkmarx One – Scan Summary & Details1899ed53-2780-4034-889b-a46575f2a1df

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant