Skip to content

add idphost configuration #10143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

add idphost configuration #10143

wants to merge 3 commits into from

Conversation

kspearrin
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 31.62%. Comparing base (fd93c76) to head (0320325).
Report is 4 commits behind head on main.

Files Patch % Lines
...onsole/organizations/settings/account.component.ts 0.00% 12 Missing ⚠️
.../services/organization/organization-api.service.ts 0.00% 2 Missing ⚠️
...n-console/models/response/organization.response.ts 0.00% 1 Missing ⚠️
...rc/auth/models/request/organization-idp.request.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10143      +/-   ##
==========================================
- Coverage   31.66%   31.62%   -0.05%     
==========================================
  Files        2620     2624       +4     
  Lines       78251    78364     +113     
  Branches    14676    14696      +20     
==========================================
+ Hits        24780    24781       +1     
- Misses      51590    51700     +110     
- Partials     1881     1883       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Logo
Checkmarx One – Scan Summary & Details14af8194-0da7-4a47-b11b-36b020592c4b

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /libs/vault/src/cipher-form/components/additional-options/additional-options-section.component.html: 11 Attack Vector

@micahblut
Copy link
Member

@kspearrin is it possible to add screenshots for design to review?

@differsthecat
Copy link
Member

@micahblut This should be the only UI change:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants