-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-17774] Build page for admin sponsored families #14243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14243 +/- ##
==========================================
- Coverage 36.17% 36.16% -0.02%
==========================================
Files 3200 3205 +5
Lines 91415 91529 +114
Branches 16369 16382 +13
==========================================
+ Hits 33068 33098 +30
- Misses 55989 56066 +77
- Partials 2358 2365 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
apps/web/src/app/billing/members/types/sponsored-family.types.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/billing/members/add-sponsorship-dialog.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/admin-console/organizations/members/members-routing.module.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you for making the requested changes.
The base branch was changed.
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17774
📔 Objective
Sponsorship Management UI Implementation Overview
This PR implements the front-end UI for managing organization-issued sponsorships. The implementation provides a complete interface for viewing existing sponsorships, adding new ones, and managing existing sponsorships, though the actual functionality is currently mocked.
Key Components
Displays a table of existing sponsored families with columns for:
Shows an empty state with appropriate messaging when no sponsorships exist
Includes loading states for better UX
Modal dialog for creating new sponsorships
Form fields:
Form validation:
Loading state during submission
This implementation provides a solid foundation for the sponsorship management feature while maintaining a clean separation between the UI and business logic, making it easier to integrate with the actual API endpoints in future work.
📸 Screenshots
Screen.Recording.2025-04-11.at.15.02.58.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes