Skip to content

[PM-17774] Build page for admin sponsored families #14243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 17, 2025
Merged

Conversation

cyprain-okeke
Copy link
Contributor

@cyprain-okeke cyprain-okeke commented Apr 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17774

📔 Objective

Sponsorship Management UI Implementation Overview
This PR implements the front-end UI for managing organization-issued sponsorships. The implementation provides a complete interface for viewing existing sponsorships, adding new ones, and managing existing sponsorships, though the actual functionality is currently mocked.
Key Components

  1. Sponsorship List View
    Displays a table of existing sponsored families with columns for:
  • Recipient email
  • Status
  • Notes
  • Actions menu

Shows an empty state with appropriate messaging when no sponsorships exist
Includes loading states for better UX

  1. Add Sponsorship Dialog
    Modal dialog for creating new sponsorships
    Form fields:
  • Email input with validation
  • Notes field for additional context

Form validation:

  • Email format validation
  • Required field validation
    Loading state during submission
  1. Sponsorship Management Actions
  • Action menu for each sponsorship with options to:
  • Resend invitation email
  • Remove sponsorship
  1. Testing Notes
  • All UI interactions are functional but mocked
  • Form validation works as expected
  • Loading states display correctly
  • Accessibility features are implemented
  1. Future Work
  • Integration with actual API endpoints
  • Implementation of real-time updates
  • Addition of more detailed error handling
  • Enhancement of the sponsorship management features

This implementation provides a solid foundation for the sponsorship management feature while maintaining a clean separation between the UI and business logic, making it easier to integrate with the actual API endpoints in future work.

📸 Screenshots

Screen.Recording.2025-04-11.at.15.02.58.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested review from a team as code owners April 11, 2025 14:08
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 26.08696% with 85 lines in your changes missing coverage. Please review.

Project coverage is 36.16%. Comparing base (08b9664) to head (e49e56c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...illing/members/add-sponsorship-dialog.component.ts 27.90% 28 Missing and 3 partials ⚠️
...lling/members/free-bitwarden-families.component.ts 29.16% 15 Missing and 2 partials ⚠️
...ling/guards/can-access-sponsored-families.guard.ts 0.00% 15 Missing ⚠️
...mbers/organization-sponsored-families.component.ts 26.66% 10 Missing and 1 partial ⚠️
.../members/organization-member-families.component.ts 30.76% 8 Missing and 1 partial ⚠️
...le/organizations/members/members-routing.module.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14243      +/-   ##
==========================================
- Coverage   36.17%   36.16%   -0.02%     
==========================================
  Files        3200     3205       +5     
  Lines       91415    91529     +114     
  Branches    16369    16382      +13     
==========================================
+ Hits        33068    33098      +30     
- Misses      55989    56066      +77     
- Partials     2358     2365       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsa96011a9-3ace-4f36-8d64-3974e3dcd1ef

Great job, no security vulnerabilities found in this Pull Request

@cyprain-okeke cyprain-okeke removed the request for review from jrmccannon April 15, 2025 10:51
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you for making the requested changes.

Base automatically changed from billing/PM-17773/f4e-nav-item to main April 16, 2025 15:58
@cturnbull-bitwarden cturnbull-bitwarden dismissed stale reviews from amorask-bitwarden, JimmyVo16, and dani-garcia April 16, 2025 15:58

The base branch was changed.

@cyprain-okeke cyprain-okeke merged commit fa26843 into main Apr 17, 2025
99 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-17774 branch April 17, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants