[PM-21184] Migrate free-bitwarden-families.component.html to Tailwind complying #14628
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14628 +/- ##
=======================================
Coverage 36.24% 36.25%
=======================================
Files 3200 3200
Lines 93163 93163
Branches 16798 16798
=======================================
+ Hits 33766 33773 +7
+ Misses 56961 56954 -7
Partials 2436 2436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
Hinton
reviewed
May 5, 2025
apps/web/src/app/billing/members/free-bitwarden-families.component.html
Outdated
Show resolved
Hide resolved
coroiu
reviewed
May 19, 2025
| @@ -82,6 +82,7 @@ import { SharedModule } from "./shared.module"; | |||
| OrganizationLayoutComponent, | |||
| VerifyRecoverDeleteOrgComponent, | |||
| VaultTimeoutInputComponent, | |||
| NoItemsModule, | |||
There was a problem hiding this comment.
issue: Please do not add to this list of declarations. If you are migrating components then please also remove them from here and make them standalone/add them to their own module
coroiu
previously approved these changes
May 19, 2025
Hinton
reviewed
May 20, 2025
Hinton
previously approved these changes
May 22, 2025
apps/web/src/app/billing/members/free-bitwarden-families.component.html
Outdated
Show resolved
Hide resolved
…ee-bitwarden-families-component' into pm-21184-Migrate-free-bitwarden-families-component
coroiu
previously approved these changes
May 23, 2025
amorask-bitwarden
previously approved these changes
May 23, 2025
Hinton
previously approved these changes
May 23, 2025
willmartian
requested changes
May 23, 2025
|
@cyprain-okeke can we just remove the no-item changes and revisit this later? We need to get the tailwind classes removed asap or they will stop working. |
…ee-bitwarden-families-component' into pm-21184-Migrate-free-bitwarden-families-component
cyprain-okeke
dismissed stale reviews from Hinton, coroiu, and amorask-bitwarden
via
0f30e9e
cyprain-okeke
requested review from
Hinton,
coroiu and
amorask-bitwarden
and removed request for
a team
|
coroiu
reviewed
May 28, 2025
| @@ -122,7 +122,6 @@ import { SharedModule } from "./shared.module"; | |||
| RemovePasswordComponent, | |||
| SetPasswordComponent, | |||
| SponsoredFamiliesComponent, | |||
| FreeBitwardenFamiliesComponent, | |||
There was a problem hiding this comment.
question: did you mean to remove this from exports?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21184
📔 Objective
/apps/web/src/app/billing/members/free-bitwarden-families.component.html
67:27 error Classname 'm-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
76:31 error Classname 'pl-1' is not a Tailwind CSS class! tailwindcss/no-custom-classname
85:13 error Classname 'mt-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
90:13 error Classname 'mt-3' is not a Tailwind CSS class! tailwindcss/no-custom-classname
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes