Skip to content

[PM-19022] Separate Manage Account Recovery and Manage Users custom role #14629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented May 5, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19022

📔 Objective

In the member dialog, enabling Manage Account Recovery currently auto-enables Manage Users. This task aims to decouple the two, allowing Manage Account Recovery to be set independently.

📸 Screenshots

Screen.Recording.2025-05-05.at.14.38.14.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (8ecb32f) to head (1c9d629).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/member-dialog/member-dialog.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14629      +/-   ##
==========================================
- Coverage   36.22%   36.22%   -0.01%     
==========================================
  Files        3197     3197              
  Lines       92335    92339       +4     
  Branches    16555    16556       +1     
==========================================
+ Hits        33452    33453       +1     
- Misses      56497    56500       +3     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsa54c7c71-0fc8-415d-83af-da57202eb760

Great job, no security vulnerabilities found in this Pull Request

@r-tome r-tome marked this pull request as ready for review May 5, 2025 13:55
@r-tome r-tome requested a review from a team as a code owner May 5, 2025 13:55
@r-tome r-tome requested a review from jrmccannon May 5, 2025 13:55
Copy link

sonarqubecloud bot commented May 8, 2025

@r-tome r-tome merged commit 0407ed5 into main May 8, 2025
98 checks passed
@r-tome r-tome deleted the ac/pm-19022/separate-account-recovery-and-manage-users-custom-role branch May 8, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants