Skip to content

PM-21057 Apply truncation in View notification bar if item name is long #14631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented May 5, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21057

📔 Objective

  • Apply truncation in View notification bar if item name is long
  • Add tool tip to item name
  • Add tool tip cipher info
  • Use spacing
  • Smoke test with and without additional message

📸 Screenshots

Screenshot 2025-05-05 at 11 10 50 AM
Screenshot 2025-05-05 at 11 10 12 AM
Screenshot 2025-05-05 at 11 16 24 AM
Screenshot 2025-05-05 at 11 16 49 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 36.24%. Comparing base (11d26a9) to head (aa89ec4).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nt/components/notification/confirmation/message.ts 0.00% 3 Missing ⚠️
.../components/notification/confirmation/container.ts 0.00% 2 Missing ⚠️
...ntent/components/notification/confirmation/body.ts 0.00% 1 Missing ⚠️
...autofill/content/components/notification/header.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14631      +/-   ##
==========================================
- Coverage   36.25%   36.24%   -0.01%     
==========================================
  Files        3193     3193              
  Lines       92432    92432              
  Branches    16603    16603              
==========================================
- Hits        33511    33504       -7     
- Misses      56517    56524       +7     
  Partials     2404     2404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsb55b5c5a-9776-451a-8dbf-42be94907477

Great job, no security vulnerabilities found in this Pull Request

@dan-livefront dan-livefront marked this pull request as ready for review May 5, 2025 16:07
@dan-livefront dan-livefront requested a review from a team as a code owner May 5, 2025 16:07
Copy link

sonarqubecloud bot commented May 7, 2025

Comment on lines +32 to +34
? html`<span title=${login.username} class=${cipherInfoSecondaryTextStyles(theme)}
>${login.username}</span
>`
Copy link
Contributor

@jprusik jprusik May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIHI, Prettier

@jprusik jprusik added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels May 8, 2025
@jprusik jprusik merged commit 61243c6 into main May 8, 2025
47 of 48 checks passed
@jprusik jprusik deleted the PM-21057-defect-apply-truncation-in-view-notification-bar-if-item-name-is-long branch May 8, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants