Skip to content

[PM-20085] Pivot trial initiation copy based on trialLength query parameter #14635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20085

📔 Objective

This PR builds on bitwarden/server#5770 to pivot some of the copy within the trial initiation flow based on the trialLength query parameter sent as part of the originating email.

When trialLength is 0, all copy updates expressed in the ticket should be visible.

If there is no trialLength parameter, it will default to 7, which will preserve the existing behavior of the trial initiation component.

📸 Screenshots

Screen.Recording.2025-05-05.at.2.17.47.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner May 5, 2025 18:27
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.23%. Comparing base (8ecb32f) to head (05da323).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-initiation/complete-trial-initiation.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14635   +/-   ##
=======================================
  Coverage   36.22%   36.23%           
=======================================
  Files        3197     3197           
  Lines       92335    92340    +5     
  Branches    16555    16560    +5     
=======================================
+ Hits        33452    33463   +11     
+ Misses      56497    56491    -6     
  Partials     2386     2386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Details2dd408da-1959-451d-927b-ba33c2107575

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.ts: 116
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
ID: WrN%2FbJQ9i30pRskKWlEHepEsvgw%3D
Attack Vector

Copy link

sonarqubecloud bot commented May 8, 2025

@amorask-bitwarden amorask-bitwarden merged commit fb01153 into main May 8, 2025
48 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-20085/trial-signup-zero-trial-days-copy branch May 8, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants