Skip to content

PM-16645 generate identity fill script refactor removal: Step 1 #14649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16645

📔 Objective

generate identity fill script refactor removal: Step 1

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.24%. Comparing base (5423ab3) to head (0aba10f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14649      +/-   ##
==========================================
- Coverage   36.34%   36.24%   -0.11%     
==========================================
  Files        3200     3200              
  Lines       93302    93161     -141     
  Branches    16855    16797      -58     
==========================================
- Hits        33911    33765     -146     
- Misses      56955    56960       +5     
  Partials     2436     2436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 6, 2025

Logo
Checkmarx One – Scan Summary & Details5e14708d-f5b9-441f-a20c-910c34268c90

Great job, no security vulnerabilities found in this Pull Request

@dan-livefront dan-livefront marked this pull request as ready for review May 6, 2025 14:57
@dan-livefront dan-livefront requested a review from a team as a code owner May 6, 2025 14:57
@jprusik
Copy link
Contributor

jprusik commented May 6, 2025

Copy link

@dan-livefront dan-livefront merged commit 88bc762 into main May 27, 2025
98 checks passed
@dan-livefront dan-livefront deleted the PM-16645-generate-identity-fill-script-refactor-removal-step-1 branch May 27, 2025 18:51
dan-livefront added a commit that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants