-
Notifications
You must be signed in to change notification settings - Fork 1.4k
PM-16649 delay fido2 page script init within mv2 feature flag removal: Step 1 #14656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PM-16649 delay fido2 page script init within mv2 feature flag removal: Step 1 #14656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14656 +/- ##
==========================================
- Coverage 36.25% 36.24% -0.01%
==========================================
Files 3193 3192 -1
Lines 92432 92418 -14
Branches 16603 16600 -3
==========================================
- Hits 33511 33499 -12
+ Misses 56517 56513 -4
- Partials 2404 2406 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
…n-mv-2-feature-flag-removal-step-1
|
} | ||
|
||
return Fido2ContentScript.PageScriptAppend; | ||
return Fido2ContentScript.PageScriptDelayAppend; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this entire method now and use Fido2ContentScript.PageScriptAppend
in the places where it's being called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but that file includes several comments explaining the reasons behind the delay for Manifest V2, as well as the actual implementation of that delay. Since the append operation is still delayed, I felt it was clearer to keep the current name for consistency and clarity.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16649
📔 Objective
delay fido2 page script init within mv2 feature flag removal: Step 1
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes