Skip to content

PM-16649 delay fido2 page script init within mv2 feature flag removal: Step 1 #14656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented May 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16649

📔 Objective

delay fido2 page script init within mv2 feature flag removal: Step 1

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.24%. Comparing base (11d26a9) to head (dc80fbb).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14656      +/-   ##
==========================================
- Coverage   36.25%   36.24%   -0.01%     
==========================================
  Files        3193     3192       -1     
  Lines       92432    92418      -14     
  Branches    16603    16600       -3     
==========================================
- Hits        33511    33499      -12     
+ Misses      56517    56513       -4     
- Partials     2404     2406       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 6, 2025

Logo
Checkmarx One – Scan Summary & Details7b62774e-9f48-4632-8ec4-593aaa603a6a

Great job, no security vulnerabilities found in this Pull Request

@dan-livefront
Copy link
Collaborator Author

@dan-livefront dan-livefront marked this pull request as ready for review May 7, 2025 15:13
@dan-livefront dan-livefront requested a review from a team as a code owner May 7, 2025 15:13
Copy link

sonarqubecloud bot commented May 7, 2025

}

return Fido2ContentScript.PageScriptAppend;
return Fido2ContentScript.PageScriptDelayAppend;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this entire method now and use Fido2ContentScript.PageScriptAppend in the places where it's being called?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but that file includes several comments explaining the reasons behind the delay for Manifest V2, as well as the actual implementation of that delay. Since the append operation is still delayed, I felt it was clearer to keep the current name for consistency and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants